added support for multiple type package URIs in ConfigurableJsonResource #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set context attribute of ROOT_ELEMENT is set Signed-off-by: Mark Hoffmann <[email protected]>
- added root_element attribute - added tests Signed-off-by: Mark Hoffmann <[email protected]>
- added root_element attribute - added tests Signed-off-by: Mark Hoffmann <[email protected]>
Signed-off-by: Ilenia Salvadori <[email protected]>
- updated tests to account for new basic model version - typePackageUris is now a String[] with empty array as default - update reader only if list of packages is not empty Signed-off-by: Ilenia Salvadori <[email protected]>
Signed-off-by: Ilenia Salvadori <[email protected]>
Signed-off-by: Ilenia Salvadori <[email protected]>
Signed-off-by: Ilenia Salvadori <[email protected]>
Signed-off-by: Ilenia Salvadori <[email protected]>
Signed-off-by: Ilenia Salvadori <[email protected]>
Signed-off-by: Ilenia Salvadori <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 188 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 28 | 3 | 157 | 0 |
Click to see the invalid file list
- org.gecko.emf.json.tests/data/exampleTypeByClass.json
- org.gecko.emf.json.tests/data/exampleTypeByName.json
- org.gecko.emf.json.tests/data/exampleTypeByURI.json
Signed-off-by: Ilenia Salvadori <[email protected]>
There was a problem hiding this comment.
license-eye has totally checked 188 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 28 | 3 | 157 | 0 |
Click to see the invalid file list
- org.gecko.emf.json.tests/data/exampleTypeByClass.json
- org.gecko.emf.json.tests/data/exampleTypeByName.json
- org.gecko.emf.json.tests/data/exampleTypeByURI.json
Signed-off-by: Ilenia Salvadori <[email protected]>
Signed-off-by: Ilenia Salvadori <[email protected]>
-refactor tests Signed-off-by: Ilenia Salvadori <[email protected]>
- added test cases for OPTION_INDENT_OUTPUT - added test cases for OPTION_SERIALIZE_DEFAULT_VALUE - added test cases for OPTION_SERIALIZE_TYPE/OPTION_TYPE_FIELD - added test cases for OPTION_USE_ID Signed-off-by: Ilenia Salvadori <[email protected]>
Signed-off-by: Ilenia Salvadori <[email protected]>
Signed-off-by: Ilenia Salvadori <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
|
@isalvadori I'm a bit lost here, as this is rather old. Is this done and can we merge it? |
|
@juergen-albert I am lost as well, as it has been quite a long time ago, but I guess, if I made the PR, it should be ready. |
juergen-albert
force-pushed
the
snapshot
branch
5 times, most recently
from
f177a27
to
e46fcd0
Compare
juergen-albert
force-pushed
the
snapshot
branch
6 times, most recently
from
f31eaca
to
0e1ae07
Compare
juergen-albert
force-pushed
the
snapshot
branch
4 times, most recently
from
e844c87
to
d4c0591
Compare
juergen-albert
force-pushed
the
snapshot
branch
4 times, most recently
from
6bbcd68
to
de2610d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ilenia Salvadori [email protected]