Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gear-builtin) Concrete error type for builtin actors #4303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lazark0x
Copy link
Member

Changed structures to use a specific error type in BuiltinActor

@Lazark0x Lazark0x added the A0-pleasereview PR is ready to be reviewed by the team label Oct 21, 2024
@Lazark0x Lazark0x requested a review from breathx October 21, 2024 13:51
@Lazark0x Lazark0x self-assigned this Oct 21, 2024
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekovalev do you have any thoughts against removal?

@@ -245,14 +245,13 @@ impl<T: Config> BuiltinRegistry<T> {

impl<T: Config> BuiltinDispatcher for BuiltinRegistry<T> {
type Error = BuiltinActorError;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert space, please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants