Sundry fixes and enhancements to the keystrokes recorder plugin #980
Conversation
Connects to the Geany "key-press" signal, rather than the GTK "key-press-event" signal. This allows recording of keys bound to other plugins. Depends on API changes made in PR #1836, so revise API version to 237. Needs to use gtk_main_do_event instead of gdk_display_put_event, and gdk_event_copy, gdk_event_free instead of g_new0, g_free.
Shows an indicator 'REC' on the status bar while recording.
The test for the bound keys ('record' and 'play') were incorrect,
causing extra modifiers to be ignored, and preventing the use of
bound keys with no modifiers.
|
You should compile with at least |
|
On Tue, 19 May 2020 21:48:05 -0700 Matthew Brush ***@***.***> wrote:
You should compile with at least `-Wall -Wextra -Werror` and make sure there's no warnings/errors. Sometimes it's useful to add `-Wno-unused-parameter` and `-DGLIB_DISABLE_DEPRECATION_WARNINGS ` to filter out the noise. You can also change into the plugin directory and do `make` from there to avoid getting bombarded by messages from other plugins.
Thanks; will do that. I was just trying to figure out how to reconfigure for GTK2; my previous build had --enable-gtk3, and now I can't seem to make it not use GTK3.
|
You should be able to put |
Fix all compiler warnings. Tidy up source layout, trying to comply with coding standards.
Use a GLib array object for storing the recorded key-press events. Minor source reformatting.
|
OK, GTK2 builds correctly too. |
|
Anything else I need to do, or is it just wait until reviewing is done? |
|
Plugin are maintained by individuals (see MAINTAINERS file) so likely have to wait for the maintainer to comment. |
Uses the Geany "key-press" signal, allowing access to all keys, including bound ones.
Fixes a bug that prevent the use of bound keys without modifiers.
Prevents playback during recording.
Displays recording indicator on the status bar.