Addons: Remove obsolete GTK_CHECK_VERSION checks #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4n
requested changes
Jun 9, 2024
addons/src/addons.c
Outdated
Comment on lines
655
to
657
| #if ! GTK_CHECK_VERSION(2, 10, 0) | ||
| gtk_widget_hide(check_systray); | ||
| #endif |
There was a problem hiding this comment.
Looks backwards, should you also remove the body? I guess the idea was not to add the option when the feature wasn't supported, wasn't it?
There was a problem hiding this comment.
This is so me...you are completely right.
Thanks for spotting, fixed.
Funny thing, this attempt to hide the option didn't work at all because in Geany itself we call gtk_widget_show_all() when creating the plugin preferences dialog and so it was shown again.
Anyway, GTK2 is long time ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.