Vimode: implement fold in vimode plugin #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previous pull request #1327 |
techee
requested changes
May 24, 2024
vimode/README
Outdated
| zR zR set 'foldlevel' to the deepest fold | ||
| za za open a closed fold, close an open fold | ||
| zc zc close a fold | ||
| zo zo open fold |
There was a problem hiding this comment.
Could you move this block to the same place as in index.txt, i.e. under section "2.5 commands starting with z"? And also within this section to the same place as in index.txt? (of course taking into account that some commands are missing)
vimode/README
Outdated
| @@ -96,7 +96,7 @@ This is an incomplete list of known limitations of the plugin: | |||
| * named registers and related commands are not implemented | |||
| * Ctrl+X mode is not implemented | |||
| * marks are not implemented | |||
| * fold commands are not implemented | |||
| * most fold commands are not implemented | |||
There was a problem hiding this comment.
I'd say "many" would be better as the most important ones are implemented now.
vimode/src/cmds/fold.c
Outdated
| #include "cmds/fold.h" | ||
| #include "utils.h" | ||
|
|
||
| /* fold command does not depend on state of parents */ |
There was a problem hiding this comment.
I'd say the comments above this define and the 2 other below is useless now and can be removed.
scresto09
force-pushed
the
vimode-fold-support-fix
branch
from
b42e68b to
5c74ce1
Compare
|
OK I did it |
|
Looks good, merged. Thanks a lot for all your contributions!!! |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supported commands are:
za / zo / zc toggle / open / close fold on one level of folding
zA / zO / zC toggle / open / close fold on all folding levels
zR / zM open / close all folds