LaTeX: Switch handling of insert (list) environments over to snippets workflow #1330
Conversation
frlan
changed the title
frlan
force-pushed
the
1071-latex-insert-list-environment-with-wrong-indent
branch
from
906f9c6 to
0192e1c
Compare
There was a problem hiding this comment.
Looks good.
As you know I'm not LaTeX expert and so I'm wondering if it is on purpose that different environments produce quite different stylings:
\begin{block}{}
_
\end{block}
\begin{itemize}
\item _
\end{itemize}
\begin{table}
_
\end{table}
For "table" and "itemize" there is a trailing space after the cursor marker. Is this intended?
"block" uses no indentation at all, "itemize" uses a tab resp. spaces and "table" uses a single space only.
latex/src/latexutils.c
Outdated
| @@ -103,6 +114,7 @@ glatex_insert_string(const gchar *string, gboolean reset_position) | |||
|
|
|||
| doc = document_get_current(); | |||
|
|
|||
|
|
|||
frlan
force-pushed
the
1071-latex-insert-list-environment-with-wrong-indent
branch
2 times, most recently
from
9313b8e to
6728529
Compare
This is fixed. I tried to re-sync the indentions |
latex/src/latexenvironments.c
Outdated
| tmpstring = g_strconcat( | ||
| "\\begin{", | ||
| environment, | ||
| "}\n\t\\item %cursor% \n\\end{", |
I cannot verify as I do not know what is the purposed variant. To me it looks inconsistent: More importantly, the rubbisch after the "block" environment is because |
frlan
force-pushed
the
1071-latex-insert-list-environment-with-wrong-indent
branch
from
5fb3c82 to
4ca8faa
Compare
|
Looks good now. As said before, I cannot judge whether the result of the snippets is as desired. To me it feels a little confusing that the element in the "itemize" environment is indented while for the other ones the cursor position is not indented. |
|
In the end it's a little matter of taste, but compare it to HTML's <ul>
<li>...</li>
</ul>and <body>
…
</body> |
This MR migrates the feature to insert any environment over to Geany's snippets workflow. Hence we don't need to bother about indention, like breaks etc. this much anymore. Also due to the cursor-feature it ensures to position the cursor at the right place , independent from the line break, indention etc.
Due to this rework it makes the code also a little more readable and fixes #1071