Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci version parser #1278

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fix ci version parser #1278

merged 2 commits into from
Oct 12, 2023

Conversation

eht16
Copy link
Member

@eht16 eht16 commented Oct 11, 2023

The previous logic failed on 2.0 to make the new version number 1.99.99. This is fixed now even though the code is not perfect or good at all but should work well enough for its purposes.

See also geany/geany#3594.

The additional log information are in pair with Geany (geany/geany@b18c76e).

@eht16 eht16 added the build system Automake build system issues label Oct 11, 2023
@eht16 eht16 added this to the 1.39.0/2.0.0 milestone Oct 11, 2023
@eht16 eht16 force-pushed the fix_ci_version_parser branch from 3613117 to 27fc3f2 Compare October 12, 2023 21:04
eht16 added 2 commits October 12, 2023 23:07
The previous logic failed on 2.0 to make the new version number 1.99.99.
This is fixed now even though the code is not perfect or good at all but
should work well enough for its purposes.
@eht16 eht16 force-pushed the fix_ci_version_parser branch from 27fc3f2 to 8a677b4 Compare October 12, 2023 21:07
@eht16 eht16 merged commit c537364 into geany:master Oct 12, 2023
2 checks passed
@eht16 eht16 deleted the fix_ci_version_parser branch October 12, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system Automake build system issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant