Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeanyLua: Support for LuaJIT and Lua 5.1-5.4 #1238

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions build/geanylua.m4
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,35 @@ AC_DEFUN([GP_CHECK_GEANYLUA],

AC_ARG_WITH([lua-pkg],
AC_HELP_STRING([--with-lua-pkg=ARG],
[name of Lua pkg-config script [[default=lua5.1]]]),
[name of Lua pkg-config script [[default=lua]]]),
[LUA_PKG_NAME=${withval%.pc}],
[LUA_PKG_NAME=lua5.1
[LUA_PKG_NAME=lua

for L in lua5.1 lua51 lua-5.1 lua; do
for L in "$LUA_PKG_NAME" lua lua53 lua54 lua52 luajit lua51; do
PKG_CHECK_EXISTS([$L],
[LUA_PKG_NAME=$L]; break,[])
done])

LUA_VERSION=5.1
LUA_VERSION_BOUNDARY=5.2
if [[ "x$LUA_PKG_NAME" = "xluajit" ]] ; then
LUA_VERSION=2.0
LUA_VERSION_BOUNDARY=3.0
elif [[ "x$LUA_PKG_NAME" = "xlua51" ]] ; then
LUA_VERSION=5.1
LUA_VERSION_BOUNDARY=5.2
elif [[ "x$LUA_PKG_NAME" = "xlua52" ]] ; then
LUA_VERSION=5.2
LUA_VERSION_BOUNDARY=5.3
elif [[ "x$LUA_PKG_NAME" = "xlua53" ]] ; then
LUA_VERSION=5.3
LUA_VERSION_BOUNDARY=5.4
elif [[ "x$LUA_PKG_NAME" = "xlua54" ]] ; then
LUA_VERSION=5.4
LUA_VERSION_BOUNDARY=5.5
else
LUA_VERSION=5.1
LUA_VERSION_BOUNDARY=5.5
fi

GP_CHECK_PLUGIN_DEPS([GeanyLua], [LUA],
[${LUA_PKG_NAME} >= ${LUA_VERSION}
${LUA_PKG_NAME} < ${LUA_VERSION_BOUNDARY}])
Expand Down
2 changes: 2 additions & 0 deletions geanylua/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ libgeanylua_la_SOURCES = \
glspi_keycmd.h \
glspi_sci.h \
glspi_ver.h \
glspi_compat.c \
glspi_compat.h \
gsdlg.h

geanylua_la_CFLAGS = \
Expand Down
2 changes: 2 additions & 0 deletions geanylua/glspi.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
#include <string.h>
#include <ctype.h>

#include "glspi_compat.h"

#include <geanyplugin.h>
#define main_widgets geany->main_widgets

Expand Down
2 changes: 1 addition & 1 deletion geanylua/glspi_app.c
Original file line number Diff line number Diff line change
Expand Up @@ -549,5 +549,5 @@ static const struct luaL_Reg glspi_app_funcs[] = {

void glspi_init_app_funcs(lua_State *L, const gchar*script_dir) {
glspi_script_dir = script_dir;
luaL_register(L, NULL,glspi_app_funcs);
luaL_setfuncs(L, glspi_app_funcs, 0);
}
55 changes: 55 additions & 0 deletions geanylua/glspi_compat.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
/* Lua compatibility functions */

#include <lua.h>
#include <lualib.h>
#include <lauxlib.h>


/*
* Compatibility functions for Lua 5.1 and LuaJIT
*/
#if LUA_VERSION_NUM==501

/* Adapted from Lua 5.2.0 */
void luaL_setfuncs (lua_State *L, const luaL_Reg *l, int nup) {
luaL_checkstack(L, nup+1, "too many upvalues");
for (; l->name != NULL; l++) { /* fill the table with given functions */
int i;
lua_pushstring(L, l->name);
for (i = 0; i < nup; i++) /* copy upvalues to the top */
lua_pushvalue(L, -(nup+1));
lua_pushcclosure(L, l->func, nup); /* closure with those upvalues */
lua_settable(L, -(nup + 3));
}
lua_pop(L, nup); /* remove upvalues */
}

#endif /* LUAJIT_VERSION_NUM */


/*
* Compatibility functions for Lua 5.1 only
*/
#if LUA_VERSION_NUM==501 && !defined LUAJIT_VERSION_NUM

void luaL_traceback (lua_State *L, lua_State *L1, const char *msg,
int level)
{
lua_getfield(L, LUA_GLOBALSINDEX, "debug");
if (!lua_istable(L, -1)) {
lua_pop(L, 1);
return;
}
lua_getfield(L, -1, "traceback");
if (!lua_isfunction(L, -1)) {
lua_pop(L, 2);
return;
}
lua_pushvalue(L, 1);
lua_pushinteger(L, 2);
lua_call(L, 2, 1);

return;
}

#endif /* LUA_VERSION_NUM */
28 changes: 28 additions & 0 deletions geanylua/glspi_compat.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
/* Lua compatibility functions */

#ifndef GLSPI_COMPAT
#define GLSPI_COMPAT 1

/*
* Compatibility functions for Lua 5.1 and LuaJIT
*/
#if LUA_VERSION_NUM==501

#define lua_rawlen(L,i) lua_objlen(L, (i))

void luaL_setfuncs (lua_State *L, const luaL_Reg *l, int nup);

#endif /* LUAJIT_VERSION_NUM */


/*
* Compatibility functions for Lua 5.1 only
*/
#if LUA_VERSION_NUM==501 && !defined LUAJIT_VERSION_NUM

void luaL_traceback (lua_State *L, lua_State *L1, const char *msg, int level);

#endif /* LUA_VERSION_NUM */


#endif /* GLSPI_COMPAT */
4 changes: 2 additions & 2 deletions geanylua/glspi_dlg.c
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ static gint glspi_choose(lua_State* L)
arg1=lua_tostring(L, 1);
}

n=lua_objlen(L,2);
n=lua_rawlen(L,2);
for (i=1;i<=n; i++) {
lua_rawgeti(L,2,i);
if (!lua_isstring(L, -1)) {
Expand Down Expand Up @@ -556,5 +556,5 @@ static const struct luaL_Reg glspi_dlg_funcs[] = {

void glspi_init_dlg_funcs(lua_State *L, GsDlgRunHook hook) {
glspi_pause_timer = hook;
luaL_register(L, NULL,glspi_dlg_funcs);
luaL_setfuncs(L, glspi_dlg_funcs, 0);
}
2 changes: 1 addition & 1 deletion geanylua/glspi_doc.c
Original file line number Diff line number Diff line change
Expand Up @@ -374,5 +374,5 @@ static const struct luaL_Reg glspi_doc_funcs[] = {
};

void glspi_init_doc_funcs(lua_State *L) {
luaL_register(L, NULL,glspi_doc_funcs);
luaL_setfuncs(L, glspi_doc_funcs, 0);
}
2 changes: 1 addition & 1 deletion geanylua/glspi_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -546,5 +546,5 @@ static const struct luaL_Reg glspi_mnu_funcs[] = {


void glspi_init_mnu_funcs(lua_State *L) {
luaL_register(L, NULL,glspi_mnu_funcs);
luaL_setfuncs(L, glspi_mnu_funcs, 0);
}
8 changes: 6 additions & 2 deletions geanylua/glspi_kfile.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
#include <lualib.h>
#include <lauxlib.h>

#include "glspi_compat.h"

#define LUA_MODULE_NAME "keyfile"
#define MetaName "_g_key_file_metatable"

Expand Down Expand Up @@ -395,8 +397,10 @@ static gint luaopen_keyfile(lua_State *L)
lua_pushstring(L,"__gc");
lua_pushcfunction(L,kfile_done);
lua_rawset(L,-3);
luaL_register(L, NULL, &kfile_funcs[1]);
luaL_register(L, LUA_MODULE_NAME, kfile_funcs);
luaL_setfuncs(L, &kfile_funcs[1], 0);
lua_newtable(L);
luaL_setfuncs(L, kfile_funcs, 0);
lua_setglobal(L, LUA_MODULE_NAME);
return 0;
}

Expand Down
28 changes: 13 additions & 15 deletions geanylua/glspi_run.c
Original file line number Diff line number Diff line change
Expand Up @@ -293,21 +293,17 @@ static const struct luaL_Reg glspi_timer_funcs[] = {
/* Catch and report script errors */
static gint glspi_traceback(lua_State *L)
{
lua_getfield(L, LUA_GLOBALSINDEX, "debug");
if (!lua_istable(L, -1)) {
lua_pop(L, 1);
return 1;
}
lua_getfield(L, -1, "traceback");
if (!lua_isfunction(L, -1)) {
lua_pop(L, 2);
return 1;
const char *msg = lua_tostring(L, 1);
if (msg == NULL) { /* is error object not a string? */
if (luaL_callmeta(L, 1, "__tostring") && /* does it have a metamethod */
lua_type(L, -1) == LUA_TSTRING) /* that produces a string? */
return 1; /* that is the message */
else
msg = lua_pushfstring(L, "(error object is a %s value)",
luaL_typename(L, 1));
}
lua_pushvalue(L, 1);
lua_pushinteger(L, 2);
lua_call(L, 2, 1);

return 1;
luaL_traceback(L, L, msg, 1); /* append a standard traceback */
return 1; /* return the traceback */
}

/*
Expand Down Expand Up @@ -393,12 +389,14 @@ static void show_error(lua_State *L, const gchar *script_file)

static gint glspi_init_module(lua_State *L, const gchar *script_file, gint caller, GKeyFile*proj, const gchar*script_dir)
{
luaL_register(L, LUA_MODULE_NAME, glspi_timer_funcs);
lua_newtable(L);
luaL_setfuncs(L, glspi_timer_funcs, 0);
glspi_init_sci_funcs(L);
glspi_init_doc_funcs(L);
glspi_init_mnu_funcs(L);
glspi_init_dlg_funcs(L, glspi_pause_timer);
glspi_init_app_funcs(L,script_dir);
lua_setglobal(L, LUA_MODULE_NAME);
set_string_token(L,tokenWordChars,GEANY_WORDCHARS);
set_string_token(L,tokenBanner,DEFAULT_BANNER);
set_string_token(L,tokenDirSep, G_DIR_SEPARATOR_S);
Expand Down
4 changes: 2 additions & 2 deletions geanylua/glspi_sci.c
Original file line number Diff line number Diff line change
Expand Up @@ -905,7 +905,7 @@ static gint glspi_find(lua_State* L)
ttf.chrg.cpMin=lua_tonumber(L,2);
ttf.chrg.cpMax=lua_tonumber(L,3);

n=lua_objlen(L,4);
n=lua_rawlen(L,4);
for (i=1;i<=n; i++) {
lua_rawgeti(L,4,i);
if (lua_isstring(L, -1)) {
Expand Down Expand Up @@ -995,5 +995,5 @@ static const struct luaL_Reg glspi_sci_funcs[] = {
};

void glspi_init_sci_funcs(lua_State *L) {
luaL_register(L, NULL,glspi_sci_funcs);
luaL_setfuncs(L, glspi_sci_funcs, 0);
}
9 changes: 6 additions & 3 deletions geanylua/gsdlg_lua.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include <lualib.h>
#include <lauxlib.h>

#include "glspi_compat.h"

#define GSDLG_ALL_IN_ONE
#include "gsdlg.h"
Expand Down Expand Up @@ -323,7 +324,7 @@ static gint gsdl_new(lua_State *L) {
if (argc>=2) {
if (!lua_istable(L,2)) { return FAIL_TABLE_ARG(2); }
}
n=lua_objlen(L,2);
n=lua_rawlen(L,2);
for (i=1;i<=n; i++) {
lua_rawgeti(L,2,i);
if (!lua_isstring(L, -1)) {
Expand Down Expand Up @@ -425,8 +426,10 @@ gint luaopen_dialog(lua_State *L)
lua_pushcfunction(L,gsdl_done);
lua_rawset(L,-3);

luaL_register(L, NULL, &gsdl_funcs[1]);
luaL_register(L, LUA_MODULE_NAME, gsdl_funcs);
luaL_setfuncs(L, &gsdl_funcs[1], 0);
lua_newtable(L);
luaL_setfuncs(L, gsdl_funcs, 0);
lua_setglobal(L, LUA_MODULE_NAME);
return 0;
}

Expand Down