geanylua: Migrate to Lua 5.3 #1235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the NULL second parameter luaL_register() is equivalent to luaL_setfuncs() as described e.g. here https://wiki.gentoo.org/wiki/Lua/Porting_notes
luaL_register() can be replaced by: 1. creating a new table 2. adding the functions to it using luaL_setfuncs() 3. publishing this table globally by lua_setglobal() Since these tables are registered just once, we don't care about the special cases described below and the "merging" problem. https://stackoverflow.com/questions/19041215/lual-openlib-replacement-for-lua-5-2
The documentation says these are identical.
LUA_GLOBALSINDEX is gone now but we can use the whole code below (the original traceback reporting code was also stolen from here): https://github.com/lua/lua/blob/cf08915d62e338c987b71c078b148490510e9fe7/lua.c#L248
|
OK, I just tried on another VM and it compiles and runs with Lua 5.4 too, without any modifications. The only time some modifications were needed was for 5.1->5.2 transition, the 5.2->5.3 transition didn't require any change either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates geanylua to Lua 5.3 (my oldish distro doesn't provide lua 5.4 so I didn't test, maybe it works too). There were mostly just simple changes. From my limited testing, everything seems to work.
Posting as an (in my opinion better) alternative to #1233