Overview: hide markers #1147
Open
Overview: hide markers #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the Scintilla Documentation: > Any markers not associated with a visible margin will be displayed as changes in background colour in the text. A width in pixels can be set for each margin. Margins with a zero width are ignored completely. All lines with markers, either builtin or used by plugins (`git-changebar`), appear on the white background, which is ugly, especially in dark themes. This MR disables rendering of markers by making them fully transparent on the overview. Additionally, it fixes `SETMARGINWIDTHN` for the last (missing) margin: > 5 margins are allocated initially numbered from 0 to SC_MAX_MARGIN (4).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Scintilla Documentation:
All lines with markers, either builtin or used by plugins (
git-changebar), appear on the white background, which is ugly, especially in dark themes.This MR disables rendering of markers by making them fully transparent on the overview.
Additionally, it fixes
SETMARGINWIDTHNfor the last (missing) margin:Before:
After:
