Gdamore/automargin #688
Merged
Gdamore/automargin #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fallback support will still work, but termite is no longer supported and users of termite are advised to switch to Alacritty.
…minal This fix is not perfect, in that it will not fix every terminal that has automargin support, but it fixes the *vast* majority of them by eliminating the hacky workaround for the automargin - essentially using the rmam capability to disable automatic wrapping at the margin.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
+ Coverage 46.17% 50.37% +4.20%
==========================================
Files 79 73 -6
Lines 8293 7512 -781
==========================================
- Hits 3829 3784 -45
+ Misses 4436 3700 -736
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@gdamore it looks like you've accidentally removed some Strikethrough fields here: I noticed that strikethrough styling no longer has any effect after bumping my tcell version. I've created an issue here: https://github.com/gdamore/tcell/issues/new |
|
Oof. My copy of the terminfo db probably lacks them. I will have to check again. Sorry.
…On Mar 2, 2024 at 7:48 PM -0800, Jesse Duffield ***@***.***>, wrote:
@gdamore it looks like you've accidentally removed some Strikethrough fields here: I noticed that strikethrough styling no longer has any effect after bumping my tcell version.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.