Fix #51 Circles and arrows are wrong on Chrome Capa boards

gbtami · Jul 24, 2024 · c96fdf3 · c96fdf3
1 parent 2be330d
commit c96fdf3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "chessgroundx",
-  "version": "10.6.1",
+  "version": "10.6.2",
   "description": "Extended lichess.org Chess UI",
   "type": "module",
   "module": "chessground.js",

diff --git a/src/svg.ts b/src/svg.ts
@@ -290,12 +290,13 @@ function arrowMargin(shorten: boolean): number {
 
 function pos2user(pos: cg.Pos, bounds: ClientRect, bd: cg.BoardDimensions): cg.NumberPair {
     let xScale, yScale;
-    if (bounds.width / bounds.height <= bd.width / bd.height) {
-        xScale = Math.min(1, bounds.width / bounds.height) * Math.max(1, bd.height / bd.width);
-        yScale = Math.min(1, bounds.height / bounds.width) * Math.max(1, bd.width / bd.height);
-    } else {
+    // Janggi/Xiangqi board needs different calculation
+    if (bd.width === 9 && bd.height === 10) {
         xScale = Math.max(1, bounds.width / bounds.height) * Math.min(1, bd.height / bd.width);
         yScale = Math.max(1, bounds.height / bounds.width) * (bd.width / bd.height);
+    } else {
+        xScale = Math.min(1, bounds.width / bounds.height) * Math.max(1, bd.height / bd.width);
+        yScale = Math.min(1, bounds.height / bounds.width) * Math.max(1, bd.width / bd.height);
     }
   return [(pos[0] - (bd.width - 1) / 2) * xScale, ((bd.height - 1) / 2 - pos[1]) * yScale];
 }