sdf2usd: set cylinder refinement parameter (backport #34) #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
The refinement parameter is 0 by default when loaded in Isaac Sim, which makes cylinders look like extruded polygons. Setting the refinement parameter to 1 makes them rounder. Signed-off-by: Steve Peters <[email protected]> (cherry picked from commit 0b699a6)
8 tasks
ahcorde
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The refinement parameter is 0 by default when loaded in Isaac Sim, which makes cylinders look like extruded polygons. Setting the refinement parameter to 1 makes them rounder.
Thanks to @rgasoto for the assistance with the OpenUSD API.
Example with unrefined cylinders
Note the polygonal shape of the pendulum bases
Example with refinement == 1
Note the rounder shape of the pendulum bases
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.This is an automatic backport of pull request #34 done by [Mergify](https://mergify.com).