Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jan 27, 2026

🦟 Bug fix

Continuing the improvements in TopicUtils, this patch optimizes MangleName(), DemangleName() and MangleType().

It replaces character-by-character string building with std::replace and adds a missing const reference to avoid copying each string.

The benchmarks show that the new functions (the ones with the 2 suffix improve the original ones).

Screenshot from 2026-01-26 18-40-31

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #788 done by [Mergify](https://mergify.com).

…788)

Signed-off-by: Carlos Agüero <[email protected]>
(cherry picked from commit 18734a4)

# Conflicts:
#	src/TopicUtils.cc
@mergify
Copy link
Contributor Author

mergify bot commented Jan 27, 2026

Cherry-pick of 18734a4 has failed:

On branch mergify/bp/gz-transport14/pr-788
Your branch is up to date with 'origin/gz-transport14'.

You are currently cherry-picking commit 18734a4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/TopicUtils.cc

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant