Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jan 27, 2026

🦟 Bug fix

Continuing the improvements in TopicUtils, this patch optimizes MangleName(), DemangleName() and MangleType().

It replaces character-by-character string building with std::replace and adds a missing const reference to avoid copying each string.

The benchmarks show that the new functions (the ones with the 2 suffix improve the original ones).

Screenshot from 2026-01-26 18-40-31

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #788 done by [Mergify](https://mergify.com).

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jan 27, 2026
@caguero caguero merged commit 072671b into gz-transport15 Jan 27, 2026
16 checks passed
@caguero caguero deleted the mergify/bp/gz-transport15/pr-788 branch January 27, 2026 14:32
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant