Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows Installation #82

Merged
merged 4 commits into from
Jan 21, 2021
Merged

Add Windows Installation #82

merged 4 commits into from
Jan 21, 2021

Conversation

JShep1
Copy link

@JShep1 JShep1 commented Jan 20, 2021 •
edited
Loading

Retargeting #71 to Citadel

@mabelzhang
add windows installation
fee3bf8 
Signed-off-by: Mabel Zhang <[email protected]>
@mabelzhang
small tweak
5367379 
Signed-off-by: Mabel Zhang <[email protected]>
@JShep1 JShep1 requested a review from maryaB-osr as a code owner January 20, 2021 07:49
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jan 20, 2021
@JShep1 JShep1 mentioned this pull request Jan 20, 2021
Closed
@codecov
Copy link

codecov bot commented Jan 20, 2021 •
edited
Loading

Codecov Report

Merging #82 (e44879f) into ign-sensors3 (ea03923) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           ign-sensors3      #82   +/-   ##
=============================================
  Coverage         77.54%   77.54%           
=============================================
  Files                23       23           
  Lines              2298     2298           
=============================================
  Hits               1782     1782           
  Misses              516      516

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea03923...e44879f. Read the comment docs.

John Shepherd added 2 commits January 20, 2021 09:19
nits
58f9a5b 
Signed-off-by: John Shepherd <[email protected]>
move docs and testing to install
e44879f 
Signed-off-by: John Shepherd <[email protected]>
@JShep1 JShep1 requested a review from iche033 as a code owner January 20, 2021 22:17
@JShep1 JShep1 requested a review from chapulina January 20, 2021 22:27
chapulina
chapulina approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this wasn't the goal of this PR, but I'll just point out that we're missing macOS installation instructions.

@chapulina chapulina merged commit f5a57f1 into ign-sensors3 Jan 21, 2021
@chapulina chapulina deleted the jshep1/mabelzhang/windows_install_sensors3 branch January 21, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@maryaB-osr maryaB-osr Awaiting requested review from maryaB-osr

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JShep1 @chapulina @mabelzhang