Merge ign-plugin1 ➡️ gz-plugin2 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not install CMakeLists.txt in loader/register By including the installation of a whole directory in the source code for loader/register, the buildsystem is installing the CMakeLists.txt files that are included in these directories. Exclude them from the final installation by using the EXCLUDE clause in CMake. Signed-off-by: Jose Luis Rivero <[email protected]>
* Use on `push` only on stable branches to avoid duplicate runs * Update project automation Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-plugin2 #136 +/- ##
===========================================
Coverage 98.26% 98.26%
===========================================
Files 23 23
Lines 748 748
===========================================
Hits 735 735
Misses 13 13 ☔ View full report in Codecov by Sentry. |
ahcorde
approved these changes
Jan 18, 2024
|
The homebrew warning will hopefully be fixed by gazebosim/gz-cmake#402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-plugin1➡️gz-plugin2Branch comparison: gz-plugin2...ign-plugin1
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)