Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable UNIT_gz_TEST on Windows #128

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Enable UNIT_gz_TEST on Windows #128

merged 1 commit into from
Oct 23, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Oct 23, 2023

🦟 Bug fix

Summary

#63 fixed installing ruby files in windows, but UNIT_gz_TEST was still not running.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested review from mxgrey and ahcorde as code owners October 23, 2023 16:17
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #128 (053d6af) into gz-plugin2 (c45ddf2) will not change coverage.
The diff coverage is n/a.

❗ Current head 053d6af differs from pull request most recent head 4121185. Consider uploading reports for the commit 4121185 to get more accurate results

@@             Coverage Diff             @@
##           gz-plugin2     #128   +/-   ##
===========================================
  Coverage       98.26%   98.26%           
===========================================
  Files              23       23           
  Lines             748      748           
===========================================
  Hits              735      735           
  Misses             13       13           

@ahcorde ahcorde merged commit d493371 into gz-plugin2 Oct 23, 2023
9 checks passed
@ahcorde ahcorde deleted the azeey-patch-1 branch October 23, 2023 16:32
@azeey
Copy link
Contributor Author

azeey commented Oct 23, 2023

It seems like the UNIT_gz_TEST is not running on windows even with this fix. @Voldivh do you mind creating an issue in gz-plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants