Removed repeated installation instructions #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
=======================================
Coverage 82.94% 82.94%
=======================================
Files 106 106
Lines 3695 3695
=======================================
Hits 3065 3065
Misses 630 630 Continue to review full report at Codecov.
|
Signed-off-by: ahcorde <[email protected]>
chapulina
suggested changes
Aug 15, 2020
tutorials/02_installation.md
Outdated
| ``` | ||
| ```{.sh} | ||
| sudo apt-add-repository -s "deb http://packages.osrfoundation.org/gazebo/ubuntu-stable $(lsb_release -c -s) main" | ||
| sudo apt-get build-dep -y ignition-physics3 |
There was a problem hiding this comment.
This won't work yet, because ignition-physics3 hasn't been released.
We could instruct users to get dependencies from these packages files once #94 is merged:
https://github.com/ignitionrobotics/ign-physics/tree/ign-physics2/.github/ci
Signed-off-by: ahcorde <[email protected]>
scpeters
reviewed
Aug 24, 2020
tutorials/02_installation.md
Outdated
| 3. Clone the repository | ||
|
|
||
| ``` | ||
| git clone https://github.com/ignitionrobotics/ign-physics -b ign-physics<#>-dev |
There was a problem hiding this comment.
ign-physics<#> is valid for release branches (remove -dev suffix), but users may also want the master branch
Signed-off-by: ahcorde <[email protected]>
|
friendly ping @scpeters |
scpeters
approved these changes
Aug 27, 2020
chapulina
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related with this issue gazebosim/docs#14
Moved install instructions to the tutorials folder.
Signed-off-by: ahcorde [email protected]