-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore message generation pipeline and generate message libraries #368
Conversation
Codecov Report
@@ Coverage Diff @@
## main #368 +/- ##
==========================================
+ Coverage 97.03% 97.21% +0.17%
==========================================
Files 9 27 +18
Lines 1081 1150 +69
==========================================
+ Hits 1049 1118 +69
Misses 32 32
|
@j-rivero is there any way to run PR jobs against jammy+? In this case, the protobuf version is missing some APIs in |
You can ignore the Focal builds. The Jammy job is already in the PR( |
7030b00
to
3e8971d
Compare
3e8971d
to
fb8b36f
Compare
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
fb8b36f
to
7e7e0b4
Compare
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
7aa4667
to
f879398
Compare
Signed-off-by: Michael Carroll <[email protected]>
56b88be
to
aeafe56
Compare
Signed-off-by: Michael Carroll <[email protected]>
74de63c
to
8c5d9f0
Compare
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few more minor comments.
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for iterating.
gazebosim/gz-sim#2087 probably needs to be merged before we merge this.
2087 depends on this one being merged/released. |
Okay, let's merge this then. |
This it the final rework of the message generation pipeline for Harmonic.
After trying multiple approaches, we decided to keep the messages in one location and generate the library as part of gz-msgs to derisk the long term supported Harmonic release.
This PR adds the new message generation pipeline, but uses it internally to keep the API similar to previous releases.
Also needs: gazebosim/gz-sensors#375
Also needs: gazebosim/gz-gui#563