Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Python3_Development_FOUND checks #662

Open
wants to merge 2 commits into
base: gz-math8
Choose a base branch
from
Open

Unify Python3_Development_FOUND checks #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2072e77
Unify Python3_Development_FOUND checks
scpeters Feb 10, 2025
dcf5151
nest logic to match gz-transport
scpeters Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,6 @@ else()
COMPONENTS Interpreter
OPTIONAL_COMPONENTS Development
)
if (NOT Python3_Development_FOUND)
GZ_BUILD_WARNING("Python development libraries are missing: Python interfaces are disabled.")
endif()
endif()

# Location of "fake install folder" used in tests
Expand Down
8 changes: 6 additions & 2 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,12 @@ gz_build_tests(TYPE UNIT SOURCES ${gtest_sources})
add_subdirectory(graph)

# Bindings subdirectories
if (Python3_Development_FOUND AND NOT SKIP_PYBIND11)
add_subdirectory(python_pybind11)
if (NOT SKIP_PYBIND11)
if (Python3_Development_FOUND)
add_subdirectory(python_pybind11)
else()
message(WARNING "Python development libraries are missing: Python interfaces are disabled.")
endif()
endif()

if (SWIG_FOUND AND NOT SKIP_SWIG)
Expand Down