Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

akshatpandya/make_api_consistent_1 #310

Closed

Conversation

akshatpandya
Copy link
Contributor

🦟 Bug fix

Fixes #301

Summary

Making API consistent for the following classes:

  1. Angle
  2. AxisAlignedBox
  3. Box
  4. Color
  5. Cylinder
  6. DiffDriveOdometry

1. Angle.cc

fix gazebosim#301

Signed-off-by: Akshat Pandya <[email protected]>
1. DiffDriveOdometry.cc
2. DiffDriveOdometry.hh

fix gazebosim#301

Signed-off-by: Akshat Pandya <[email protected]>
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #310 (faf2c31) into main (e0cc08f) will not change coverage.
The diff coverage is 94.11%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files          66       66           
  Lines        6004     6004           
=======================================
  Hits         5949     5949           
  Misses         55       55           
Impacted Files Coverage Δ
src/Angle.cc 89.65% <93.75%> (ø)
src/DiffDriveOdometry.cc 90.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0cc08f...faf2c31. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant