Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add venv as a dependency since the following step needs it. #566

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

arjo129
Copy link
Contributor

@arjo129 arjo129 commented Jan 17, 2025

🦟 Bug fix

Fixes #

Summary

By default python venvs maynot be installed in ubuntu. I ran into this issue when building from source.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

By default python venvs maynot be installed in ubuntu. I ran into this issue when building from source. 

Signed-off-by: Arjo Chakravarty <[email protected]>
@arjo129 arjo129 requested a review from azeey as a code owner January 17, 2025 07:39
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jan 17, 2025
@arjo129 arjo129 merged commit b3667e8 into master Jan 17, 2025
5 checks passed
@arjo129 arjo129 deleted the arjo/fix/add_venv_req branch January 17, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants