Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionic/install_windows_src: Added protobuf dependency #516

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Sep 15, 2024

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#1545

Summary

Python bindings need protobuf conda package.

Please note that libprotobuf is currently already available in version 5.x, while protobuf only in version 4.x. So this PR downgrades libprotobuf to 4.x, too. But I was able to successfully build Gazebo with libprotobuf 4.x.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde merged commit a7c9c3c into gazebosim:master Sep 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gz-transport: Python Support
2 participants