Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of upload-artifact action in deploy workflow #496

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Fix use of upload-artifact action in deploy workflow #496

merged 2 commits into from
Sep 4, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 4, 2024 •
edited
Loading

🦟 Bug fix

Summary

The deploy workflow has been silently failing since upload-artifact Action has been updated to include a new parameter include-hidden-files (see actions/upload-artifact#602). The first commit of this PR sets the parameter if-no-files-found to error so that the workflow fails if no files were uploaded. The second commit fixes the actual problem by setting include-hidden-files=true.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey
Fail workflow if no files were found
9304d16 
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from mabelzhang as a code owner September 4, 2024 15:43
@azeey
Include hidden files
8ce649e 
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from j-rivero September 4, 2024 16:13
@azeey azeey merged commit 280702e into gazebosim:master Sep 4, 2024
5 checks passed
@azeey azeey deleted the fix_workflow branch September 4, 2024 17:06
@azeey azeey mentioned this pull request Sep 5, 2024
Merged
8 tasks
azeey added a commit to azeey/docs that referenced this pull request Jan 9, 2025
@azeey
Fix use of upload-artifact action in deploy workflow (gazebosim#496)
c021d5d 
* Fail workflow if no files were found

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Include hidden files

Signed-off-by: Addisu Z. Taddese <[email protected]>

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

@mabelzhang mabelzhang Awaiting requested review from mabelzhang

@j-rivero j-rivero Awaiting requested review from j-rivero

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azeey @iche033