-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the releasing process - General Overview #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, Jose! The general structure works great! I just have minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Jose! This helped me understand the releasing process. I left some minor comments
release.md
Outdated
stable. | ||
* Linux prerelease binaries: | ||
http://packages.osrfoundation.org/gazebo/{ubuntu/debian}-prerelease | ||
* MacosX prerelease binaries (same than stable): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean by "same than stable"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about 3faffdc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This helped but I was still slightly confused. Is this #140 (comment) correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct. I think it's currently fixed.
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
…s into releasing_releasepy
Co-authored-by: Jenn Nguyen <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]>
…s into releasing_releasepy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is some extra information about brew
that is relevant
- brew infers the version number from the tarball URL if it is a stable release number (X.Y.Z)
- for prerelease tarballs (with
~preX
) or urls that point directly to a specific commit on github, aversion
field is set explicitly (see an unreleased version of ignition-edifice for example). we typically include the date and commit has in the custom version for a specific commit - brew complains if it thinks that a new version is less than a previously committed version and gives
brew audit
complaints. if this has happened, you can bump theversion_scheme
field (see example). this acts like a version greater than the major version for purposes ofbrew audit
checks
revision 1 | ||
# sha256 is the 256 hash of binary bottle for the macOS version lala | ||
sha256 "41af286dc0b172ed2f1ca934fd2278de4a1192302ffa07087cea2682e7d372e3" => :lala | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the wrong snippet to show I think. here is a brew formula revision:
the bottle do
block is automatically generated, so we shouldn't recommend people to change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed in 935ec1a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM! Most of my comments are grammar/formatting related. Thanks for putting this together, @j-rivero!
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
I think that we can leave this to next section where there is more information about how we implement the whole thing.
Added a note about unstable packages in 9d712e1. For prereleases packages in homebrew-simulation I see them use the usual scheme of
Same than in the first point, probably to be added to next document or inside the FAQ. |
Co-authored-by: Ashton Larkin <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
…s into releasing_releasepy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I left some minor comments
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]>
Co-authored-by: Ashton Larkin <[email protected]>
This is the first part of the documentation of the Ignition releasing process. This first part is dedicated to describe the general overview of different pieces affecting the releasing process. I'm unsure at this moment if I will increase this section with other subsections as I wrote the rest of the process but these ones should provide a bit of context for the people wanted to know about the process.
Feel free to comment globally about the structure, missing sections or anything you think is important.