Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the releasing process - General Overview #140

Merged
merged 45 commits into from
Mar 19, 2021
Merged

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Feb 4, 2021

This is the first part of the documentation of the Ignition releasing process. This first part is dedicated to describe the general overview of different pieces affecting the releasing process. I'm unsure at this moment if I will increase this section with other subsections as I wrote the rest of the process but these ones should provide a bit of context for the people wanted to know about the process.

Feel free to comment globally about the structure, missing sections or anything you think is important.

@j-rivero j-rivero requested a review from maryaB-osr as a code owner February 4, 2021 18:49
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, Jose! The general structure works great! I just have minor comments.

release.md Outdated Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
releasing/images/general_context.svg Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
releasing/versioning_pre_nightly.md Outdated Show resolved Hide resolved
releasing/versioning_pre_nightly.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Jose! This helped me understand the releasing process. I left some minor comments

release.md Outdated Show resolved Hide resolved
release.md Outdated
stable.
* Linux prerelease binaries:
http://packages.osrfoundation.org/gazebo/{ubuntu/debian}-prerelease
* MacosX prerelease binaries (same than stable):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean by "same than stable"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about 3faffdc?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helped but I was still slightly confused. Is this #140 (comment) correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct. I think it's currently fixed.

release.md Outdated Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
releasing/versioning_pre_nightly.md Outdated Show resolved Hide resolved
releasing/versioning_pre_nightly.md Outdated Show resolved Hide resolved
releasing/versioning_pre_nightly.md Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
j-rivero and others added 21 commits February 10, 2021 15:21
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]>
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is some extra information about brew that is relevant

  1. brew infers the version number from the tarball URL if it is a stable release number (X.Y.Z)
  2. for prerelease tarballs (with ~preX) or urls that point directly to a specific commit on github, a version field is set explicitly (see an unreleased version of ignition-edifice for example). we typically include the date and commit has in the custom version for a specific commit
  3. brew complains if it thinks that a new version is less than a previously committed version and gives brew audit complaints. if this has happened, you can bump the version_scheme field (see example). this acts like a version greater than the major version for purposes of brew audit checks

revision 1
# sha256 is the 256 hash of binary bottle for the macOS version lala
sha256 "41af286dc0b172ed2f1ca934fd2278de4a1192302ffa07087cea2682e7d372e3" => :lala
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the wrong snippet to show I think. here is a brew formula revision:

the bottle do block is automatically generated, so we shouldn't recommend people to change it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed in 935ec1a

Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM! Most of my comments are grammar/formatting related. Thanks for putting this together, @j-rivero!

release.md Outdated Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
releasing/versioning_pre_nightly.md Outdated Show resolved Hide resolved
releasing/versioning_pre_nightly.md Outdated Show resolved Hide resolved
releasing/versioning_pre_nightly.md Outdated Show resolved Hide resolved
releasing/versioning_pre_nightly.md Outdated Show resolved Hide resolved
releasing/versioning_pre_nightly.md Outdated Show resolved Hide resolved
@j-rivero
Copy link
Contributor Author

j-rivero commented Mar 3, 2021

  • brew infers the version number from the tarball URL if it is a stable release number (X.Y.Z)

I think that we can leave this to next section where there is more information about how we implement the whole thing.

  • for prerelease tarballs (with ~preX) or urls that point directly to a specific commit on github, a version field is set explicitly (see an unreleased version of ignition-edifice for example). we typically include the date and commit has in the custom version for a specific commit

Added a note about unstable packages in 9d712e1. For prereleases packages in homebrew-simulation I see them use the usual scheme of X.Y.Z~pre. Do you have any particular example of a different way of handling it?

  • brew complains if it thinks that a new version is less than a previously committed version and gives brew audit complaints. if this has happened, you can bump the version_scheme field (see example). this acts like a version greater than the major version for purposes of brew audit checks

Same than in the first point, probably to be added to next document or inside the FAQ.

Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I left some minor comments

releasing/versioning_pre_nightly.md Outdated Show resolved Hide resolved
releasing/versioning_pre_nightly.md Outdated Show resolved Hide resolved
releasing/versioning_pre_nightly.md Show resolved Hide resolved
j-rivero and others added 3 commits March 8, 2021 18:15
release.md Outdated Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
release.md Outdated Show resolved Hide resolved
releasing/versioning_pre_nightly.md Outdated Show resolved Hide resolved
releasing/versioning_pre_nightly.md Outdated Show resolved Hide resolved
@adlarkin adlarkin requested review from adlarkin and removed request for maryaB-osr March 16, 2021 15:08
@j-rivero j-rivero merged commit fedc3e9 into master Mar 19, 2021
@j-rivero j-rivero deleted the releasing_releasepy branch March 19, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants