Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: support versionless package names #1246

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scpeters
Copy link
Contributor

Part of #1244, needed to fix CI in gazebosim/gz-sim#2726.

While testing a gazebo package name without the major version in gazebosim/gz-sim#2726, the Windows build fails when trying to find a package with matching name in the colcon workspace. The last message is:

# BEGIN SECTION: Update package gz-sim10 from gz to ignition
Packages in workspace:
gz-cmake4
gz-common6
gz-fuel_tools10
gz-gui10
gz-math8
gz-msgs11
gz-physics8
gz-plugin3
gz-rendering9
gz-sensors9
gz-sim
gz-tools2
gz-transport14
gz-utils3
sdformat15
Failed to find package ignition-gazebo10 in workspace.
Failed with error #1.

The code currently checks for gz-packageN then ignition-packageN. This PR adds an additional step in between, so that it checks for gz-packageN, then gz-package, then ignition-packageN.

I started a test jobs of ignition-utils1 and gz-utils3 with this branch to confirm that it doesn't break existing jobs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant