Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filesystem token for Brew. Use crendential plugin #1213

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

j-rivero
Copy link
Contributor

The PR removes the injection of the GITHUB token into jenkins-scripts/lib/_homebrew_github_setup.bash to work using the same variable injected via credentials plugin. @scpeters if you please find a chance to test it, appreciated.

@scpeters
Copy link
Contributor

the DSL modifies 2 jobs:

I'll test these two jobs separately

@scpeters
Copy link
Contributor

scpeters commented Nov 23, 2024

this is easy to test; I'll just rerun the following job with this branch after deploying the DSL from this branch. I expect it to open a pull request to revert sdformat 15.1.1 back to sdformat 15.1.0 (I won't merge it). If it pushes a branch and opens a pull request, then it counts as a success

@scpeters
Copy link
Contributor

scpeters commented Nov 23, 2024

this is easy to test; I'll just rerun the following job with this branch after deploying the DSL from this branch. I expect it to open a pull request to revert sdformat 15.1.1 back to sdformat 15.1.0 (I won't merge it). If it pushes a branch and opens a pull request, then it counts as a success

deploying DSL: Build Status https://build.osrfoundation.org/job/_dsl_brew_release/938/

running generic-release-homebrew_pull_request_updater: Build Status https://build.osrfoundation.org/job/generic-release-homebrew_pull_request_updater/1608/

@scpeters
Copy link
Contributor

If it pushes a branch and opens a pull request, then it counts as a success

deploying DSL: Build Status https://build.osrfoundation.org/job/_dsl_brew_release/938/

running generic-release-homebrew_pull_request_updater: Build Status https://build.osrfoundation.org/job/generic-release-homebrew_pull_request_updater/1608/

success! osrf/homebrew-simulation#2891

Copy link
Contributor

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code paths are the same between the two jobs, so I'm comfortable approving after that test

@j-rivero
Copy link
Contributor Author

j-rivero commented Nov 23, 2024

Great! Thanks so much for doing the test. One credential less!

@j-rivero j-rivero merged commit fadf0d4 into master Nov 23, 2024
1 check passed
@j-rivero j-rivero deleted the jrivero/remove_filesystem_token branch November 23, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants