-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove filesystem token for Brew. Use crendential plugin #1213
Conversation
Signed-off-by: Jose Luis Rivero <[email protected]>
the DSL modifies 2 jobs:
I'll test these two jobs separately |
this is easy to test; I'll just rerun the following job with this branch after deploying the DSL from this branch. I expect it to open a pull request to revert sdformat 15.1.1 back to sdformat 15.1.0 (I won't merge it). If it pushes a branch and opens a pull request, then it counts as a success |
deploying DSL: https://build.osrfoundation.org/job/_dsl_brew_release/938/ running generic-release-homebrew_pull_request_updater: https://build.osrfoundation.org/job/generic-release-homebrew_pull_request_updater/1608/ |
success! osrf/homebrew-simulation#2891 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code paths are the same between the two jobs, so I'm comfortable approving after that test
Great! Thanks so much for doing the test. One credential less! |
The PR removes the injection of the GITHUB token into
jenkins-scripts/lib/_homebrew_github_setup.bash
to work using the same variable injected via credentials plugin. @scpeters if you please find a chance to test it, appreciated.