Fixes for gazebo-install-one_liner-homebrew-amd64 #1064
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the following failed CI job and made a few fixes after some debugging:
That first failure has the following error:
The fix in 8e85201 is to use
${BREW_BINARY}
to match the rest of the script.After that I saw a
brew doctor
complaint aboutsbin
not being in thePATH
:The fix is in 115c708, copied from #931.
I then made a change in 70c04c4 and 46f55b9 to use a local copy of the script in CI, and after it passed, I reverted to
curl
ing the script and followed the recommendation to get it from https://get.gazebosim.orghttps://build.osrfoundation.org/view/ign-citadel/job/gazebo-install-one_liner-homebrew-amd64/2963/
The CI job should be fixed once this is merged.