Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for gazebo-install-one_liner-homebrew-amd64 #1064

Merged
merged 6 commits into from
Nov 13, 2023

Conversation

scpeters
Copy link
Contributor

I noticed the following failed CI job and made a few fixes after some debugging:

That first failure has the following error:

++ brew cleanup --prune-prefix
./scripts/jenkins-scripts/lib/_homebrew_cleanup.bash: line 34: brew: command not found

The fix in 8e85201 is to use ${BREW_BINARY} to match the rest of the script.

After that I saw a brew doctor complaint about sbin not being in the PATH:

Warning: Homebrew's "sbin" was not found in your PATH but you have installed
formulae that put executables in /usr/local/sbin.
Consider setting your PATH for example like so:
  echo 'export PATH="/usr/local/sbin:$PATH"' >> ~/.zshrc

The fix is in 115c708, copied from #931.

I then made a change in 70c04c4 and 46f55b9 to use a local copy of the script in CI, and after it passed, I reverted to curling the script and followed the recommendation to get it from https://get.gazebosim.org

Build Status https://build.osrfoundation.org/view/ign-citadel/job/gazebo-install-one_liner-homebrew-amd64/2963/

The CI job should be fixed once this is merged.

Use ${BREW_BINARY} for consistency.

Signed-off-by: Steve Peters <[email protected]>
Add brew sbin to PATH.

Signed-off-by: Steve Peters <[email protected]>
Update curl command to use get.gazebosim.org, but
comment it out for now.

Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from j-rivero as a code owner November 10, 2023 02:18
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestion about curl parameters, looks good.

jenkins-scripts/gazebo-one_liner-homebrew.bash Outdated Show resolved Hide resolved
@j-rivero j-rivero merged commit 37e2210 into master Nov 13, 2023
1 check passed
@j-rivero j-rivero deleted the scpeters/brew_cleanup_fix branch November 13, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants