Update theme-ui.md #39038
Open
Update theme-ui.md #39038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link to Typography.js on the Gatsby Theme-UI documentation page was leading to a 404 error. This commit updates the link to point to the correct URL: [new-link](https://www.gatsbyjs.com/docs/using-typography-js/). Closes gatsbyjs#39034 - Updated the link in `docs/theme-ui.md` - Verified that the new link works correctly This resolves the broken link issue mentioned in issue gatsbyjs#39034 .
gatsbot
bot
added
the
status: triage needed
emmron
approved these changes
Jul 13, 2024
emmron
approved these changes
Jul 13, 2024
emmron
approved these changes
Jul 13, 2024
emmron
approved these changes
Jul 13, 2024
emmron
approved these changes
Jul 13, 2024
emmron
approved these changes
Jul 13, 2024
emmron
approved these changes
Jul 13, 2024
emmron
approved these changes
Jul 13, 2024
emmron
approved these changes
Jul 13, 2024
emmron
approved these changes
Jul 13, 2024
abhinavverma03
commented
Jul 13, 2024
There was a problem hiding this comment.
The link to Typography.js on the Gatsby Theme-UI documentation page was leading to a 404 error. This commit updates the link to point to the correct URL: new-link.
Closes #39034
- Updated the link in
docs/theme-ui.md - Verified that the new link works correctly
This resolves the broken link issue mentioned in issue #39034 .
|
Hey, is there any issue with the changes I made? |
serhalp
requested changes
Jul 30, 2024
| @@ -6,7 +6,7 @@ title: Theme UI | |||
| It allows you to style any component in your application with typographic, color, and layout values defined in a shared theme object. | |||
| Theme UI is currently used in Gatsby's official themes, | |||
| but it can be used in any Gatsby site or React application. | |||
| It includes the [Emotion][] CSS-in-JS library along with additional utilities for styling [MDX][] and using configurations and themes from [Typography.js][]. | |||
| It includes the [Emotion][] CSS-in-JS library along with additional utilities for styling [MDX][] and using configurations and themes from [Typography.js](https://www.gatsbyjs.com/docs/using-typography-js/). | |||
There was a problem hiding this comment.
Suggested change
| It includes the [Emotion][] CSS-in-JS library along with additional utilities for styling [MDX][] and using configurations and themes from [Typography.js](https://www.gatsbyjs.com/docs/using-typography-js/). | |
| It includes the [Emotion][] CSS-in-JS library along with additional utilities for styling [MDX][] and using configurations and themes from [Typography.js][]. |
Could you update the URL at the bottom of this file instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link to Typography.js on the Gatsby Theme-UI documentation page was leading to a 404 error. This commit updates the link to point to the correct URL: Typography.js.
Fixes #39034
docs/theme-ui.mdThis resolves the broken link issue mentioned in issue #39034 .