Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin install errors #484

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Fix plugin install errors #484

merged 2 commits into from
Mar 7, 2024

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented Mar 7, 2024

Ticket(s)

Related to #376

Description

This PR introduces a new flag to disable Tar and Zip Slip verification to allow isolated environment like Docker extract and install plugins into absolute paths.

Related PRs

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have added tests for my changes.
  • I have signed all the commits.

Legal Checklist

Add flag to disable path slip verification for Docker and other isolated envs
Add more output messages
Fix errors raised by functions (not to mix error and *GatewayDError)
Get absolute path of the output directory
Check if the output directory exists before extracting the archive
@mostafa mostafa merged commit a785cb3 into main Mar 7, 2024
3 of 4 checks passed
@mostafa mostafa deleted the fix-plugin-install-errors branch March 7, 2024 23:13
smnmna99 pushed a commit that referenced this pull request Mar 13, 2024
* Return an error when an illegal path is used to prevent Zip and Tar slip
* Add flag to disable path slip verification for Docker and other isolated envs
* Add more output messages
* Fix errors raised by functions (not to mix error and *GatewayDError)
* Check if the output directory exists before extracting the archive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant