feat: git keywords and file targeting #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change divider character from middot (·) to horizontal line (─) to distinguish from test progress dots - Ensure batch_summary always ends with newline for consistency (fixes trailing % in zsh)
Add three new git file keywords that can be used to filter tools to run on specific sets of changed files: - unstaged: files with unstaged changes (git diff --name-only) - modified: all changed files vs HEAD (git diff --name-only HEAD) - untracked: new files not yet tracked (git ls-files --others) These follow the existing staged keyword pattern and are recognized as reserved keywords in the argument parser.
Extract shared behavior into Git::Base class. Each keyword class now only defines its OPTIONS constant. Consolidate tests into single file with command verification for each keyword. Also add keyword methods to Arguments::Files so keywords translate to file lists (unstaged, modified, untracked). Note: File lists are collected but not yet passed to tools - that requires completing the File Targeting feature. - Reduces ~140 lines to ~53 lines of implementation - Reduces ~170 lines to ~63 lines of tests - Adds command string tests to catch OPTIONS typos
Enable tools to receive specific files when Reviewer is invoked with file arguments or git keywords. Tools with `files:` config in their settings now append the file list to their review command. - Add files_flag, files_separator, supports_files? to Tool::Settings - Add files parameter to Command::String with files_string builder - Wire up Command#target_files to pass files from arguments - Add files config to rubocop, reek, and fasterer in .reviewer.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
staged,unstaged,modified,untracked) for targeting files by git statusfiles:config receive specific filesChanges
Git Keywords
rvw staged- files staged for commitrvw unstaged- files with unstaged changesrvw modified- all modified files (staged + unstaged)rvw untracked- new files not yet trackedFile Targeting
Tools with
files:configuration now receive the file list:rvw modified rubocop # Runs: bundle exec rubocop --parallel --color lib/changed.rb test/changed_test.rbConfigured for: rubocop, reek, fasterer
Output Fixes
Test plan
rvw modified rubocop