Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom themes #113

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Add custom themes #113

wants to merge 27 commits into from

Conversation

gareththegeek
Copy link
Owner

Adds support for custom themes

Themes must be placed in their own sub-directory in client/public/themes
Each theme must have

  • a theme.css which defines fonts and colours
  • one or more language files en.json, de.json etc.
  • an entry in `client/public/themes/index.json

@sentinelgreg
Copy link
Collaborator

Couple of notes in jumping to making my own themes:

  • We should use more intuitive, semantic names for CSS variables.

--background-color vs. --colour-black

  • It would be great to facilitate a clear cut, tight testing loop for theme makers. They can upload the files to the appropriate folder
  • Some way to easily copy and paste a "template" theme directory for editing.
  • readme.md docs AND template theming docs need some context. Tutorialization, examples, etc.
  • lang.json files should have comments with context around where each snippet will show up.
  • How do we use imported fonts? Can that be invoked in theme.css?

I'm happy to do as much of that as I can.

@@ -2,5 +2,7 @@
"themes": [
{ "name": "Agon", "folder": "agon", "default": true },
{ "name": "Test", "folder": "test" }
{ "name": "Void Legend", "folder": "void legend" }
{ "name": "Deathmatch Island", "folder": "dmi" }
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folder should not contain spaces

@gareththegeek
Copy link
Owner Author

Comments are not supported in json files. I made all the translation keys the same as the text in the vanilla agon theme so you can see from context where they go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants