Skip to content

Conversation

@nickytd
Copy link
Collaborator

@nickytd nickytd commented Feb 10, 2026

How to categorize this PR?
/kind cleanup
/area logging

What this PR does / why we need it:
This PR introduces small quality-of-life improvements to the logging infrastructure, focusing on consistency and clarity. It standardizes configuration key naming conventions to ensure consistent use of "isin" prefixes across Shoot and Seed controller mappings, making configuration more predictable. Additionally, it enhances logging diagnostics in the DQueBatchProcessor by adding path details to log context and removes verbose log statements that added noise without significant value. The PR also updates the Go version from 1.25.6 to 1.25.7.

Code changes:

  • go.mod: Bump Go version from 1.25.6 to 1.25.7
  • pkg/client/dque_batch_processor.go:
    • Import strings package for path manipulation
    • Replace "component" log key with "path" key showing full dqueue directory path (dir + name)
    • Remove redundant verbose log statements from exportBatch and Shutdown methods
  • pkg/config/config.go: Fix inconsistent ConfigMap key naming in boolean field mappings:
    • Shoot config: Fix typos in keys like "sendlogstoshootwhenisinnreadystate" → "sendlogstoshootwhenisinreadystate" (remove double 'n')
    • Shoot config: Standardize keys to consistently use "isin" prefix (e.g., "sendlogstoshootwhenisinhibernatingstate", "sendlogstoshootwhenisindeletionstate")
    • Seed config: Apply same standardization (e.g., "sendlogstoseedwhenshootisinreadystate", "sendlogstoseedwhenshootisinwakingstate", "sendlogstoseedwhenshootisindeletionstate", "sendlogstoseedwhenshootisinrestorestate", "sendlogstoseedwhenshootisinmigrationstate")

Additional context:
These changes improve code maintainability by ensuring consistent naming patterns and better logging context for troubleshooting, while eliminating log noise that could clutter observability systems.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
The configuration key changes are backward-incompatible if users were relying on the inconsistent key names. Please verify that no existing configurations depend on the old typo-ed keys.

Release note:

Standardized configuration key naming conventions for Shoot and Seed controller log routing (fixes typos, adds consistent "isin" prefixes). Enhanced DQueBatchProcessor logging with path details and reduced log verbosity. Updated Go to 1.25.7.
  • 🔄 Regenerate and Update Summary

📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!

PR Bot Information

Version: 1.17.53 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

  • Correlation ID: f0d57a40-0662-11f1-81df-45660ed8e720
  • Event Trigger: issue_comment.edited

@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Something that is not needed anymore and can be cleaned up area/logging Logging related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 10, 2026
@nickytd nickytd self-assigned this Feb 10, 2026
Copy link
Member

@dnaeon dnaeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2026
@gardener-prow
Copy link

gardener-prow bot commented Feb 10, 2026

LGTM label has been added.

DetailsGit tree hash: 47a74dc5f4e5580ef0d67e334d72fad5b24d37f4

@gardener-prow
Copy link

gardener-prow bot commented Feb 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dnaeon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2026
@nickytd nickytd merged commit a1dd291 into master Feb 10, 2026
40 checks passed
@nickytd nickytd deleted the small-improvements branch February 10, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/logging Logging related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants