Skip to content

Redact credentials from endpoint when logging #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickytd merged 4 commits into from
Feb 6, 2026
+10 −2
Merged

Redact credentials from endpoint when logging #434

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54e1239
Redact credentials from endpoint when logging
relusc Feb 6, 2026
757d732
Redact only when logging
relusc Feb 6, 2026
4ba3a10
create function for redaction
relusc Feb 6, 2026
26a050e
linter: satisfy nlreturn linter feedback
nickytd Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions pkg/plugin/logging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func NewPlugin(informer cache.SharedIndexInformer, cfg *config.Config, logger lo
metrics.Clients.WithLabelValues(client.Seed.String()).Inc()

logger.Info("logging plugin created",
"seed_client_url", l.seedClient.GetEndPoint(),
"seed_client_url", redactCredentialsFromEndpoint(l.seedClient.GetEndPoint()),
"seed_queue_name", cfg.OTLPConfig.DQueConfig.DQueName,
)

Expand Down Expand Up @@ -165,8 +165,9 @@ func (l *logging) Close() {
if l.controller != nil {
l.controller.Stop()
}

l.logger.Info("logging plugin stopped",
"seed_client_url", l.seedClient.GetEndPoint(),
"seed_client_url", redactCredentialsFromEndpoint(l.seedClient.GetEndPoint()),
"seed_queue_name", l.cfg.OTLPConfig.DQueConfig.DQueName,
)
}
Expand All @@ -188,3 +189,10 @@ func (l *logging) isDynamicHost(dynamicHostName string) bool {
l.dynamicHostRegexp != nil &&
l.dynamicHostRegexp.MatchString(dynamicHostName)
}

// Helper function to redact possible `user:password` credentials from configured endpoint before logging
func redactCredentialsFromEndpoint(endpoint string) string {
r := regexp.MustCompile(`//.*@`)

return r.ReplaceAllString(endpoint, "//xxxxx@")
}
Loading