This repository has been archived by the owner on Sep 11, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is closed an issue related to bad ID of sticky wrapper element:
id="undefined-sticky-wrapper"
Current line from master branch defines wrapper ID:
It means if your sticky element has
id="dummy"
, wrapper will haveid="dummy-sticky-wrapper"
.If your sticky element does not have an ID - wrapper will have
id="undefined-sticky-wrapper"
.There is a problem when we have a few sticky elements on page without id (sidebar and header etc.)
it's not good to have two wrappers with that same id "undefined-sticky-wrapper"
How about to change this line with:
In this case wrapper id with will be more readable and it will be always unique on page (because timestamp is unique).