Fix WreathProductElementList
to not modify its list argument
#5801
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
StructuralCopy
withShallowCopy
inWreathProductElementListNC
.Otherwise an immutable list representation from the input gets replaced with the wreath product element even outside of the scope of
WreathProductElementList
.Setup:
Current behaviour: list l gets overwritten by output w.
Expected behaviur: list l should be unchanged
Text for release notes
Fix a bug in
WreathProductElementList
for generic wreath products, which replaced an immutable list from the input with the constructed wreath product element.