-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NaturalGModule
for obtaining the natural module of a matrix group
#5798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
I think NaturalGModule
would be a natural name; this term occurs for example in the description of PermutationGModule
.
If the function shall eventually cover also the case of permutation groups then the argument that specifies the field cannot be avoided; then perhaps PermutationGModule
need not be documented anymore.
(Perhaps for another pull request: The check of arguments of GModuleByMats
can be improved; a given dimension is ignored if the list of matrices is nonempty, and it is not checked that the matrices really fit together; for example, GAP accepts the input GModuleByMats([[[Z(2)]], [[1]]], GF(2))
.)
0234601
to
5ea8143
Compare
NaturalGModule
for obtaining the natural module of a matrix group
ab353f2
to
6a72ec1
Compare
Also fix usage error message for GModuleByMats
6a72ec1
to
6343f96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the tests is failing, a cross-reference should be adjusted.
(This is actually not an error in the sense of GAPDoc, but somehow more rules are imposed on the GAP manuals; unfortunately some of these rules are wrong.)
Co-authored-by: Thomas Breuer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the tests pass.
Also fix usage error message for GModuleByMats.
The main gist is: instead of this
you can now write this
which just is quite convenient when dealing with matrix groups over finite fields.
A field can be specified as an optional second argument in case the matrix groups is defined over one field, but we want the module over another. But perhaps I should just drop it?
This is a draft, as there is no documentation yet for the new function (just a placeholder), and also a TODO comment here or there in the code.
Before I fine tune it I wanted to check if this seems sensible. Also I wonder whether the function's name should be changed to e.g. just
GModule
, or perhapsNaturalGModule
, or something else.