be more restrictive in the default method of SmallGeneratingSet, in order to avoid error messages
#5795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBreuer
added
kind: bug: unexpected error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed change resolves #5542/#5790 in the sense that one does no longer get error messages when a call of
SmallGeneratingSetdelegates to its generic methodSMALLGENERATINGSETGENERIC.The idea is to try element comparisons (via
\=or\<) and membership tests only if the filtersCanEasilyCompareElements,CanEasilySortElements,CanEasilyTestMembershipindicate that these operations will be cheap.This change may yield worse results of
SmallGeneratingSetin situations where the abovementioned filters are not set but where the old function was successful.For an example where this happens, see the comment by @Stefan-Kohl in the discussion of #5790.
(But note that for that group, in fact
SmallGeneratingSetdoes not call the generic method, and the result ofSmallGeneratingSetis not as good as that of the old generic method.)If this proposal is acceptable, I will add some tests and improve also the documentation of
SmallGeneratingSet.