Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in general, do not use a known Name value in PrintObj #5701

Closed
wants to merge 3 commits into from
Closed

in general, do not use a known Name value in PrintObj #5701

wants to merge 3 commits into from

Commits on Oct 15, 2024

  1. in general, do not use a known Name value in PrintObj 

    Use a known `Name` value in `PrintObj` only if a global variable
with this name exists.
    @ThomasBreuer
    ThomasBreuer committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    58abade View commit details
    Browse the repository at this point in the history

  2. change the approach 

    - remove the offending `PrintObj` method
- install individual `PrintObj` methods for the few objects
  that are affected (in our test suite) by this change
    @ThomasBreuer
    ThomasBreuer committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    54da6b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. treat also Cyclotomics specially

    @ThomasBreuer
    ThomasBreuer committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2eee091 View commit details
    Browse the repository at this point in the history