[BATCH] fix warning in model library and clarify use of batch facets for beta distribution #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -20,6 +20,7 @@ | |||
| import java.time.temporal.ChronoUnit; | |||
| import java.util.ArrayList; | |||
| import java.util.Arrays; | |||
| import java.util.Collections; | |||
There was a problem hiding this comment.
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.71 to 5.00, threshold = 4
|
Could you provide an example model for the fix you did on factorial ? |
| .filter(p -> p.getMinValue(scope) != null && p.getMaxValue(scope) != null).map(p -> p).toList(); | ||
|
|
||
| parameters = parameters == null ? params : parameters; | ||
| parameters = parameters == null ? getParams(currentExperiment) : parameters; |
There was a problem hiding this comment.
✅ Getting better: Complex Method
explore decreases in cyclomatic complexity from 12 to 11, threshold = 9
| @@ -91,11 +91,11 @@ | |||
| optional = true, | |||
| doc = @doc ("The number of sample required.")), | |||
| @facet ( | |||
| name = Exploration.SAMPLE_FACTORIAL, | |||
| name = BetaExploration.BOOTSTRAP, | |||
There was a problem hiding this comment.
❌ New issue: Overall Code Complexity
This module has a mean cyclomatic complexity of 4.43 across 7 functions. The mean complexity threshold is 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.