Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed a short feedback form at the bottom of the tutorial #988

Merged
merged 9 commits into from
Sep 7, 2018

Conversation

bebatut
Copy link
Member

@bebatut bebatut commented Aug 27, 2018

To solve #981, a feedback form can be embedded at the bottom of the tutorial (with the tutorial name already filled):

screen shot 2018-08-28 at 14 00 13

There is 2 issues with the current implementation:

  • I can not get rid of the header of the form (previous screenshot)

    I tried to play with it both on Google form side and CSS. But no way to get rid of it. I think we will keep it this way

  • When leaving the page, a pop up box open with "This page is asking you to confirm that you want to leave - data you have entered may not be saved" (on Firefox)

@willdurand any idea?

@bebatut bebatut force-pushed the short_feedback_form branch from ee86d85 to 77f4d37 Compare August 28, 2018 12:07
@shiltemann
Copy link
Member

shiltemann commented Aug 28, 2018

We have also added a script to the google form to automatically post the responses to a github issue. This way feedback is transparent to everybody. I have added a disclaimer to the form telling people their feedback will be anonymous but public

edit: there is now also an option in the form to keep feedback confidential, then it will be recorded by the form but not posted to github

@@ -221,12 +221,16 @@ <h3>{% icon congratulations %} Congratulations on successfully completing this t

<hr>

<p>Please let us know what you thought of this tutorial below! This feedback should be about the training materials themselves only. If tools were not working or missing, please contact the administrators of the Galaxy instance you used. </p>

<p>Please note that your feedback will be anonymous, but <strong>publicly visible</strong> (on this <a href="https://github.com/galaxyproject/training-material/issues/989">GitHub issue</a>).</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this optional, maybe?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a checkbox to the forms to make feedback confidential, in which case it will not be posted to the github issue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks @shiltemann !

@mblue9
Copy link
Contributor

mblue9 commented Aug 28, 2018

Automatically posting feedback to Github!..very cool!! (It never even occurred to me that that was possible 😄)

@shiltemann shiltemann merged commit 88dc379 into master Sep 7, 2018
@shiltemann
Copy link
Member

thanks a lot @bebatut!

@shiltemann shiltemann deleted the short_feedback_form branch September 7, 2018 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants