Add abstraction for popping connection dictionary to model. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #96 +/- ##
=======================================
Coverage 40.41% 40.41%
=======================================
Files 48 48
Lines 1915 1915
Branches 433 433
=======================================
Hits 774 774
Misses 1025 1025
Partials 116 116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jmchilton
force-pushed
the
pop_connection
branch
8 times, most recently
from
0d71530 to
6db82e8
Compare
jmchilton
force-pushed
the
pop_connection
branch
from
6db82e8 to
a837dca
Compare
nsoranzo
reviewed
Dec 2, 2024
| ConnectDict = dict | ||
|
|
||
|
|
||
| EmbeddedLink = TypedDict("EmbeddedLink", {"$link": str}) |
There was a problem hiding this comment.
@jmchilton This EmbeddedLink type seems unused and generates this warning when building the docs:
WARNING: invalid signature for autoattribute ('gxformat2.model::EmbeddedLink.$link') [autodoc]
WARNING: don't know which module to import for autodocumenting 'gxformat2.model::EmbeddedLink.$link' (try placing a "module" or "currentmodule" directive in the document, or giving an explicit module name) [autodoc]
Can we drop it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.