[24.0] Fix various invocation export issues #19215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the step is not a job step. This broke in galaxyproject@ab2f76c where ``` # Safeguard: imported_invocation_step was implicitly merged into this Session prior to SQLAlchemy 2.0. self.sa_session.add(imported_invocation_step) ``` was replaced with ``` ensure_object_added_to_session(imported_invocation, session=self.sa_session) ``` which seems like a small typo-like bug.
Without this change jobs like `__EXTRACT_DATASET__` would not be included in a history or invocation export`.
…f hdca points to self
It's a temporary path and probably doesn't make much sense in the context of an imported invocation.
mvdbeek
force-pushed
the
24_0_fix_various_invocation_export_issues
branch
from
6bccf37 to
91fc1d8
Compare
|
Test failures should all be unrelated. |
4 tasks
mvdbeek
force-pushed
the
24_0_fix_various_invocation_export_issues
branch
from
1503622 to
e301ec9
Compare
|
Still all unrelated if someone wants to merge |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18927 and #18995:
How to test the changes?
(Select all options that apply)
License