Merge pull request #93 from gaelj/release

Release 0.3.1
gaelj · Feb 5, 2024 · 39f3fa3 · 39f3fa3
2 parents 6ac1983 + 8a07bd6
commit 39f3fa3
Show file tree

Hide file tree

Showing 10 changed files with 28 additions and 15 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.3.1 - 2024-02-06
+
+### 🐛 Fix a bug
+
+- Fix shift-tab in csv not working on last cell
+
+### 🥅 Catch errors
+
+- Silence errors when DOM elements are no longer available in Diagrams (SVG) and file upload (main div)
+
 ## 0.3.0 - 2024-02-06
 
 ### ✨ Introduce new features

diff --git a/CodeMirror6/CodeMirror6.csproj b/CodeMirror6/CodeMirror6.csproj
@@ -9,7 +9,7 @@
     <AssemblyName>GaelJ.BlazorCodeMirror6</AssemblyName>
     <IsPackable>true</IsPackable>
     <PackageId>GaelJ.BlazorCodeMirror6</PackageId>
-    <Version>0.3.0</Version>
+    <Version>0.3.1</Version>
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>

diff --git a/CodeMirror6/NodeLib/src/CmColumns.ts b/CodeMirror6/NodeLib/src/CmColumns.ts
@@ -58,7 +58,9 @@ function getRelativeColumnOffset(text: string, separator: string, position: numb
             offset++
         }
     }
-    return offset
+    if (previous)
+        return previousColumnOffset - position
+    else return offset
 }
 
 export function columnStylingPlugin(separator: string): Extension {

diff --git a/CodeMirror6/NodeLib/src/CmDiagrams.ts b/CodeMirror6/NodeLib/src/CmDiagrams.ts
@@ -52,6 +52,8 @@ function readSvgDimensions(svgContent: string): { width: number, height: number
     const parser = new DOMParser()
     const svg = parser.parseFromString(svgContent, "image/svg+xml")
     const svgElement = svg.getElementsByTagName("svg")[0]
+    if (!svgElement)
+        return { width: 0, height: 0 }
     const width = svgElement.getAttribute("width")
     const height = svgElement.getAttribute("height")
     return { width: parseInt(width), height: parseInt(height) }

diff --git a/CodeMirror6/NodeLib/src/CmFileUpload.ts b/CodeMirror6/NodeLib/src/CmFileUpload.ts
@@ -7,7 +7,6 @@ import { CMInstances } from "./CmInstance"
 export function getFileUploadExtensions(id: string, setup: CmSetup)
 {
     const overlayId = `${id}-file-upload`
-    // check if the document already contains the overlay
     if (document.getElementById(overlayId)) return []
 
     const overlay = document.createElement("div")
@@ -30,8 +29,10 @@ export function getFileUploadExtensions(id: string, setup: CmSetup)
     `
     let depth = 0
 
-    // Append the overlay to your CodeMirror container
-    const editorContainer = document.getElementById(id) // Replace with your actual container ID
+    const editorContainer = document.getElementById(id)
+    if (!editorContainer) {
+        return []
+    }
     editorContainer.style.position = 'relative'
     editorContainer.appendChild(overlay)
 

diff --git a/Examples.BlazorServer/Examples.BlazorServer.csproj b/Examples.BlazorServer/Examples.BlazorServer.csproj
@@ -4,7 +4,7 @@
     <Nullable>enable</Nullable>
     <IsPackable>false</IsPackable>
     <ImplicitUsings>enable</ImplicitUsings>
-    <Version>0.3.0</Version>
+    <Version>0.3.1</Version>
   </PropertyGroup>
   <ItemGroup>
     <SupportedPlatform Include="browser" />

diff --git a/Examples.BlazorServerInteractive/Examples.BlazorServerInteractive.csproj b/Examples.BlazorServerInteractive/Examples.BlazorServerInteractive.csproj
@@ -4,7 +4,7 @@
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
     <IsPackable>false</IsPackable>
-    <Version>0.3.0</Version>
+    <Version>0.3.1</Version>
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="Sentry.AspNetCore" Version="3.41.4" />

diff --git a/Examples.BlazorWasm/Examples.BlazorWasm.csproj b/Examples.BlazorWasm/Examples.BlazorWasm.csproj
@@ -4,7 +4,7 @@
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
     <IsPackable>false</IsPackable>
-    <Version>0.3.0</Version>
+    <Version>0.3.1</Version>
   </PropertyGroup>
   <ItemGroup>
     <SupportedPlatform Include="browser-wasm" />

diff --git a/Examples.Common/Examples.Common.csproj b/Examples.Common/Examples.Common.csproj
@@ -5,7 +5,7 @@
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <IsPackable>false</IsPackable>
-    <Version>0.3.0</Version>
+    <Version>0.3.1</Version>
   </PropertyGroup>
   <ItemGroup>
     <SupportedPlatform Include="browser" />

diff --git a/NEW_CHANGELOG.md b/NEW_CHANGELOG.md
@@ -1,9 +1,7 @@
-### ✨ Introduce new features
+### 🐛 Fix a bug
 
-- Add commands to insert markdown table and horizontal rule
-- Implement csv and tsv with padded column widths (Does not support multiline cells)
-- Add Tab and Shift-Tab keymaps to csv mode, to navigate columns
+- Fix shift-tab in csv not working on last cell
 
-### 🎨 Improve structure / format of the code
+### 🥅 Catch errors
 
-- Improve eq() of emojiWidget
+- Silence errors when DOM elements are no longer available in Diagrams (SVG) and file upload (main div)