Skip to content

Commit

Permalink
Merge pull request #97 from gaelj/release
Browse files Browse the repository at this point in the history
Release 0.3.3
  • Loading branch information
gaelj authored Feb 6, 2024
2 parents 8950a9d + f066d7a commit 0150b59
Show file tree
Hide file tree
Showing 9 changed files with 23 additions and 26 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## 0.3.3 - 2024-02-06

### 🐛 Fix a bug

- Fix crash when creating new diagram
- Fix typo in readme (imports)

## 0.3.2 - 2024-02-06

### ⚡️ Improve performance
Expand Down
2 changes: 1 addition & 1 deletion CodeMirror6/CodeMirror6.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<AssemblyName>GaelJ.BlazorCodeMirror6</AssemblyName>
<IsPackable>true</IsPackable>
<PackageId>GaelJ.BlazorCodeMirror6</PackageId>
<Version>0.3.2</Version>
<Version>0.3.3</Version>
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
Expand Down
14 changes: 8 additions & 6 deletions CodeMirror6/NodeLib/src/CmDiagrams.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,19 +149,21 @@ class DiagramWidget extends WidgetType {
const container = document.createElement('div')
container.setAttribute('aria-hidden', 'true')

if (this.svgContent === null) {
if (this.svgContent === null || this.svgContent === undefined) {
container.innerHTML = `Loading ${this.language} diagram...`
container.style.fontStyle = 'italic'
container.style.color = 'gray'
}
else {
container.innerHTML = this.svgContent
const svgElement = container.getElementsByTagName("svg")[0]
svgElement.setAttribute('aria-hidden', 'true')
svgElement.style.backgroundColor = 'white'
svgElement.style.maxHeight = '800px'
svgElement.style.maxWidth = 'calc(100% - 2em)'
svgElement.style.objectFit = 'scale-down'
if (svgElement !== null && svgElement !== undefined) {
svgElement.setAttribute('aria-hidden', 'true')
svgElement.style.backgroundColor = 'white'
svgElement.style.maxHeight = '800px'
svgElement.style.maxWidth = 'calc(100% - 2em)'
svgElement.style.objectFit = 'scale-down'
}
container.style.fontStyle = ''
container.style.color = ''
container.style.backgroundColor = 'transparent'
Expand Down
2 changes: 1 addition & 1 deletion Examples.BlazorServer/Examples.BlazorServer.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
<ImplicitUsings>enable</ImplicitUsings>
<Version>0.3.2</Version>
<Version>0.3.3</Version>
</PropertyGroup>
<ItemGroup>
<SupportedPlatform Include="browser" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<IsPackable>false</IsPackable>
<Version>0.3.2</Version>
<Version>0.3.3</Version>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Sentry.AspNetCore" Version="3.41.4" />
Expand Down
2 changes: 1 addition & 1 deletion Examples.BlazorWasm/Examples.BlazorWasm.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<IsPackable>false</IsPackable>
<Version>0.3.2</Version>
<Version>0.3.3</Version>
</PropertyGroup>
<ItemGroup>
<SupportedPlatform Include="browser-wasm" />
Expand Down
2 changes: 1 addition & 1 deletion Examples.Common/Examples.Common.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
<Version>0.3.2</Version>
<Version>0.3.3</Version>
</PropertyGroup>
<ItemGroup>
<SupportedPlatform Include="browser" />
Expand Down
16 changes: 2 additions & 14 deletions NEW_CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,4 @@
### ⚡️ Improve performance

- Add "Visible" property to allow hiding the editor without destroying it

### ✨ Introduce new features

- Add linting that checks csv column count relative to first line
- Disable initial setting of line wrapping in csv mode

### 🐛 Fix a bug

- Fix tabulating csv columns skipped the last / first ones

### 📝 Add or update documentation

- Update README
- Fix crash when creating new diagram
- Fix typo in readme (imports)
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ Visit the [live demo](https://gaelj.github.io/BlazorCodeMirror6/) to see the com
## Quick Start

- add the nuget package [GaelJ.BlazorCodeMirror6](https://www.nuget.org/packages/GaelJ.BlazorCodeMirror6/)
- Add `@using using GaelJ.BlazorCodeMirror6`, `@using GaelJ.BlazorCodeMirror6.Commands` and `@using GaelJ.BlazorCodeMirror6.Models.BlazorCodeMirror6` in your `_Imports.razor` or page/component
- Add `@using GaelJ.BlazorCodeMirror6`, `@using GaelJ.BlazorCodeMirror6.Commands` and `@using GaelJ.BlazorCodeMirror6.Models` in your `_Imports.razor` or page/component
- Use the `<CodeMirror6Wrapper />` component as demonstrated in `Examples.Common/Example.razor`

## Examples
Expand Down

0 comments on commit 0150b59

Please sign in to comment.