Allow the messages to be overridable. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
approved these changes
Nov 10, 2022
blueyed
reviewed
Nov 10, 2022
| @@ -48,6 +48,8 @@ class FSMTransitionMixin(object): | |||
| fsm_field = ['state'] | |||
| change_form_template = 'fsm_admin/change_form.html' | |||
| default_disallow_transition = not getattr(settings, 'FSM_ADMIN_FORCE_PERMIT', False) | |||
| success_message_template = _('%(obj)s successfully set to %(new_state)s') | |||
| error_message_template = _('Error! %(obj)s failed to %(transition)s') | |||
There was a problem hiding this comment.
Would be nice to have a trailing dot here by default (since it is a whole sentence), but this might cause translations to become outdated etc, so maybe better to keep it as before by default.
(However the missing dot would be the only reason to override/customize it for me)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.