Add wide character formatting and output support to console in wincolor_sink. #3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes printing of unicode characters to the windows console such as microsecond suffix for std::chrono types.
|
Thanks @DominikGrabiec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes printing of unicode characters to the windows console such as microsecond suffix for
std::chronotypes.This is a proper implementation of #3013 as discussed in that issue. I had to open a new pull request because of some automated stuff Github did.
Please let me know if there's anything else I need to do.
For the v2 branch it might be useful to have a
wchar_toutput option for all Windows loggers as sometimes things like Visual Studio assume a certain encoding even in files.