async_msg: take ownership of filename/funcname
#2935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timblechmann
force-pushed
the
feature/async_sourceloc_ownership
branch
from
387a06f
to
38ff02b
Compare
tt4g
reviewed
Nov 9, 2023
CMakeLists.txt
Outdated
| @@ -113,6 +113,8 @@ else() | |||
| set(SPDLOG_WCHAR_FILENAMES OFF CACHE BOOL "non supported option" FORCE) | |||
| endif() | |||
|
|
|||
| set(SPDLOG_ASYNC_OWNING_SOURCELOC_STRINGS BOOL "Async loggers take owership of source_loc strings" OFF) | |||
There was a problem hiding this comment.
You should use option() instead of set().
Also, it seems halfway to define a new option in this position.
Why not define it where other options are defined together (e.g., after option(SPDLOG_DISABLE_DEFAULT_LOGGER ...))?
the async logger cannot ensure that filename/funcname pointers are still valid at the time when the async worker is executed: * filename/funcname may be provided by a VM * filename/funcname may point to a readonly text field, in a shared object that had been `dlclose`d we add an api that can be enabled via `SPDLOG_ASYNC_OWNING_SOURCELOC_STRINGS` to take ownership of the strings
timblechmann
force-pushed
the
feature/async_sourceloc_ownership
branch
from
38ff02b
to
bfb3a8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the async logger cannot ensure that filename/funcname pointers are still valid at the time when the async worker is executed:
dlclosedwe add an api that can be enabled via
SPDLOG_ASYNC_OWNING_SOURCELOC_STRINGSto take ownership of the stringsfixes #2867