Graph-based code coverage representation #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some functions that are "lifted" from the disassembler database during caching of functions metadata might be external objects. And these "functions" are data and cannot be covered. Remove them from functions metadata database.
Feature of exporting coverage data from chosen function as GraphML file is added to Coverage Overview context menu. Such representation can help to find most important uncovered functions in the code and provide a convenient way to analyze code coverage as a system of functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Here is the implementation of graph-based code coverage representation, which we proposed in #103.
With this solution, LightHouse users are able to export a graph of functions with coverage information to GraphML format, using corresponding button in Coverage Overview context menu. For more details, see updated README.md.
One specific commit that I should mention is 6ce5738.
During our tests with IDA Pro, we found out that IDA API function
idautils.Functions()that is used for collecting functions metadata, returns the list of objects, where not all objects are actually functions. For example, data from a segment of externals objects might belongs to a list of functions, but these "functions" are data and cannot be covered. Such thing happens, for example, in IDA Pro for ELF binaries. Without the mentioned commit, exported GraphML file may contain extra nodes with wrong coverage and size information, so we fixed that problem in that pull request too. Moreover, the fix excludes the same unwanted data from Coverage Overview table.P.S. Sorry for the long delay :)